fix(yfinance): normalize class-share symbols before Yahoo requests#7536
Open
gyx09212214-prog wants to merge 1 commit into
Open
fix(yfinance): normalize class-share symbols before Yahoo requests#7536gyx09212214-prog wants to merge 1 commit into
gyx09212214-prog wants to merge 1 commit into
Conversation
ed79d63 to
0bdcc22
Compare
0bdcc22 to
b0b4027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BRK.AandBF.B, converting them to Yahoo's dash-form symbols at the request boundary.yf_download(...)and yfinanceTicker(...)-based equity/fundamental request paths while preserving the requested dot-form symbol in OpenBBsymboloutput fields.yf.downloadticker arguments, multi-symbol historical output, and a quote fetcherTicker("BRK-A")path.Why
Users can use OpenBB's dot convention from #6702 while Yahoo still receives the dash-form symbols it expects. This keeps the mapping vendor-specific and avoids changing global symbol semantics.
Scope
openbb-yfinanceis changed.A,B, andCso one-letter Yahoo exchange suffixes such asVOD.Lremain unchanged.Validation
From
openbb_platform/providers/yfinance:python -m pytest tests/test_yfinance_helpers.py -q- 19 passedpython -m ruff check openbb_yfinance tests/test_yfinance_helpers.py- passedRefs #6702